Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760357 Ulrich Schwickerath <ulrich.schwickerath@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.schwickerath@xxxxxxx --- Comment #8 from Ulrich Schwickerath <ulrich.schwickerath@xxxxxxx> 2011-12-07 05:31:03 EST --- I may be a bit late now I just realised but it took me a while to do an Informal Package Review ======================= Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [ ] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: [ ] Rpmlint output: $ rpmlint rubygem-systemu-2.4.1-1.fc17.src.rpm rubygem-systemu.src: W: spelling-error Summary(en_US) stdout -> stout, std out, std-out rubygem-systemu.src: W: spelling-error Summary(en_US) stderr -> std err, std-err, stander rubygem-systemu.src: W: spelling-error Summary(en_US) pid -> peed, dip, pud rubygem-systemu.src: W: spelling-error %description -l en_US stdout -> stout, std out, std-out rubygem-systemu.src: W: spelling-error %description -l en_US stderr -> std err, std-err, stander rubygem-systemu.src: W: spelling-error %description -l en_US pid -> peed, dip, pud rubygem-systemu.src: W: non-standard-group Unspecified rubygem-systemu.src: W: no-cleaning-of-buildroot %install 1 packages and 0 specfiles checked; 0 errors, 8 warnings. $ rpmlint rubygem-systemu-2.4.1-1.fc17.noarch.rpm rubygem-systemu.noarch: W: spelling-error Summary(en_US) stdout -> stout, std out, std-out rubygem-systemu.noarch: W: spelling-error Summary(en_US) stderr -> std err, std-err, stander rubygem-systemu.noarch: W: spelling-error Summary(en_US) pid -> peed, dip, pud rubygem-systemu.noarch: W: spelling-error %description -l en_US stdout -> stout, std out, std-out rubygem-systemu.noarch: W: spelling-error %description -l en_US stderr -> std err, std-err, stander rubygem-systemu.noarch: W: spelling-error %description -l en_US pid -> peed, dip, pud rubygem-systemu.noarch: W: non-standard-group Unspecified 1 packages and 0 specfiles checked; 0 errors, 7 warnings. [?] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : b7c29f05686420511861276594fa64f5 MD5SUM gem package from source rpm: c95eb1dd231cac73b11224a9d3ee35c2 MD5SUM upstream package: c95eb1dd231cac73b11224a9d3ee35c2 [x] Package is not known to require ExcludeArch, OR: Arches excluded: none Why: [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: [?] Package should compile and build into binary rpms on all supported architectures. Tested on: [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. === Issues === none found === Final Notes === /usr/lib/ruby/gems/1.8/cache/ is not owned by the package, is used and provided by the rubygem rpm which is present as dependency. I could not test the correct functioning of the package nor if it builds on all architecture. As it is a noarch package I don't see a reason why it should not ================ *** APPROVED *** ================ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review