Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=751119 --- Comment #2 from Tomas Smetana <tsmetana@xxxxxxxxxx> 2011-12-07 04:47:32 EST --- Hello, I tried to run rpmlint with the provided src.rpm: perl-Judy.src: E: no-changelogname-tag perl-Judy.src: W: invalid-license GPL perl-Judy.src: W: no-url-tag perl-Judy.src:21: W: unversioned-explicit-provides perl(Judy::1::_impl) perl-Judy.src:21: W: unversioned-explicit-provides perl(Judy::1::_obj) perl-Judy.src:21: W: unversioned-explicit-provides perl(Judy::1::_tie) perl-Judy.src:22: W: unversioned-explicit-provides perl(Judy::L::_impl) perl-Judy.src:22: W: unversioned-explicit-provides perl(Judy::L::_obj) perl-Judy.src:22: W: unversioned-explicit-provides perl(Judy::L::_tie) perl-Judy.src:23: W: unversioned-explicit-provides perl(Judy::SL::_impl) perl-Judy.src:23: W: unversioned-explicit-provides perl(Judy::SL::_obj) perl-Judy.src:23: W: unversioned-explicit-provides perl(Judy::SL::_tie) perl-Judy.src:23: W: unversioned-explicit-provides perl(Judy::SL::_dump) perl-Judy.src:24: W: unversioned-explicit-provides perl(Judy::HS::_impl) perl-Judy.src:24: W: unversioned-explicit-provides perl(Judy::HS::_obj) perl-Judy.src:24: W: unversioned-explicit-provides perl(Judy::HS::_tie) perl-Judy.src:25: W: unversioned-explicit-provides perl(Judy::Mem::_impl) perl-Judy.src:26: W: unversioned-explicit-provides perl(Judy::_tie) perl-Judy.src:33: W: setup-not-quiet perl-Judy.src:37: W: rpm-buildroot-usage %build perl Build.PL --install_path arch=${RPM_BUILD_ROOT}/%{perl_sitearch} --install_path libdoc=$RPM_BUILD_ROOT/%{_mandir}/man3 perl-Judy.src:50: W: macro-in-comment %{_name_version} 1 packages and 0 specfiles checked; 1 errors, 20 warnings The missing changelog is definitely not OK. According to the README file the license should be the same as Perl itself, which is "(GPL+ or Artistic) and (GPLv2+ or Artistic) and Copyright Only and MIT and Public Domain and UCD" however the Perl packaging guildelines [0] suggest "GPL+ or Artistic"... I'm lost. As for the other warnings: the %clean version suggests the provided .spec is not a final version(?). So it would be good to finalize it probably... Since this is a Perl package I would rather someone more experienced to take a look at it. However: there are errors that have to be corrected anyway. [0] https://fedoraproject.org/wiki/Packaging/Perl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review