[Bug 758166] [EPEL] - Review Request -- thrift 0.6.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=758166

--- Comment #4 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2011-12-05 09:55:57 EST ---
I don't see why not, although, you should be prepared for users to file bugs
that you are not at the latest version. :)

* To support Fedora, you'll want to make sure that all the conditionals are
valid for Fedora (where %{rhel} is NULL) (and probably also enable the
functionality that Fedora has but RHEL does not, like csharp, erlang, haskell,
java, ruby).

* I think the php subpackage needs a copy of LICENSE too.

* You will also want to add the appropriate php requires, see:
https://fedoraproject.org/wiki/Packaging:EPEL#PHP_ABI_Check_Handling

* This conditional is weird:

%if %{_arch} == x86_64
Requires:       perl(Math::BigInt)
%endif

Just Requires: perl(Math::BigInt) and be done with it. :)

* make check disappeared, I assume it doesn't work well?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]