Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756046 --- Comment #3 from Matthias Clasen <mclasen@xxxxxxxxxx> 2011-11-28 09:49:49 EST --- Review checklist: package name: ok spec file name: ok packaging guidelines: ok, apart from whats mentioned in the previous comment license: ok license field: ok license file: ok spec language: ok spec readable: ok upstream sources: see the rpmlint complaint above buildable: ok, module missing BR excludearch: ok buildrequires: see initial comment, needs gobject-introspection-devel locale handling: ok ldconfig: ok system libs: ok relocatable: ok dir ownership: see above, must own /lib/udisks2 duplicate files: ok permissions: ok. note that defattr() is no longer needed macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review