Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756046 --- Comment #2 from Matthias Clasen <mclasen@xxxxxxxxxx> 2011-11-24 12:38:48 EST --- Building in mock reveals a missing BuildRequires: gobject-introspection-devel After adding that line, it builds ok. rpmlint output: rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/udisks2-*.rpm udisks2.src: W: spelling-error %description -l en_US udisks -> disks, u disks, Saudis udisks2.src:98: E: hardcoded-library-path in /lib/udisks2/udisksd udisks2.src: W: file-size-mismatch udisks-1.90.0.git20111122.tar.bz2 = 584775, http://people.freedesktop.org/~david/udisks-1.90.0.git20111122.tar.bz2 = 640107 udisks2.x86_64: W: unexpanded-macro dependency dbus >= %{dbus_version} %{dbus_version} udisks2.x86_64: W: spelling-error %description -l en_US udisks -> disks, u disks, Saudis udisks2.x86_64: E: executable-sourced-script /etc/profile.d/udisksctl-bash-completion.sh 0755L udisks2.x86_64: E: non-standard-dir-perm /var/lib/udisks2 0700L udisks2.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.UDisks2.conf udisks2.x86_64: W: no-manual-page-for-binary umount.udisks2 3 packages and 0 specfiles checked; 3 errors, 6 warnings. Some things to fix here: - The hardcoded library path is fine, but you need to add a %dir /lib/udisks2 to own the directory. - The file size mismatch should be investigated and fixed. - You need to define dbus_version - Should make /etc/profile.d/udisksctl-bash-completion.sh non-executable (and, as already mentioned, consider moving it) - You should probably add a comment in the file list explaining the permissions of /var/lib/udisks2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review