Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755093 --- Comment #4 from Mads Kiilerich <mads@xxxxxxxxxxxxx> 2011-11-19 21:22:56 EST --- Reviewers usually complain when the package is updated without bumping the nvr ... Some quick comments: I didn't expect from rpm that it automatically removed ghost files when the package was removed, but now I see that it does that and I can see that the spec now relies on that. Great. Why not make the requirements hard and make the %post actions unconditional: require grub2 and /usr/share/pixmaps/bootloader/fedora.icns (or system-logos) (which is provided by fedora-logos and generic-logos). (I guess that it - also for reuse in RHEL - would be convenient if a more generic name like system.icns was used.) Do the blessing of the partition really belong as a part of the package installation? That seems a bit too magic to me. I would expect that to be handled by anaconda. Regarding extra stuff in grub2-efi grub.efi: Is it the plan to keep /boot/grub2-efi/? What should it be used for, and how and for what should it be referenced? Or should its content be moved 100% to /boot/efi/EFI/redhat/? (I still think it would be better to run grub2-efi-install to /boot/efi, just like grub2-install is run for bios booting.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review