Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718502 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pikachu.2014@xxxxxxxxx --- Comment #4 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2011-11-19 21:15:37 EST --- The packaging looks quite good and the application seems to work. Anyway: - dockapps.org seems dead unfortunately; is there an alternate place where the WM applet are now available? - in %install, you don't have to refer to %{_builddir} to manually install files: install -p -m 755 %{name} %{buildroot}%{_bindir} You can even discard all the mkdir commands, since install can create the destination directories on the fly: %install install -D -p -m 755 %{name} %{buildroot}%{_bindir}/%{name} install -D -p -m 755 %{SOURCE1} %{buildroot}%{_mandir}/man1/%{name}.1.gz - about the man page: where does it come from? If you didn't write it, you should specify its source. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review