Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=744339 --- Comment #10 from Jiri Hladky <hladky.jiri@xxxxxxxxx> 2011-11-14 16:34:36 EST --- Hi Richard, thanks for your comments. I have cleaned-up a SPEC file a little bit, removing some unnecessary comments:-) > 1. The release tag should start with 1, not 0. I didn't know that, fixed. > 2. If you're not going to build for EL 5 you can remove the following from your spec file: My intention was to provide rpm for EPEL-5, EPEL-6. The developer has stated that he has used RHEL and Fedora to develop the software. I think it woould be nice to provide packages for RHEL. > 3. The devel subpackage should be arch specific. Fixed. > 4. Leave the "*" off of. Fixed. I have uploaded new version of SPEC file and source rpm to this location: Spec URL: http://jhladky.fedorapeople.org/dieharder.spec SRPM URL: http://jhladky.fedorapeople.org/dieharder-3.31.1-1.fc16.src.rpm Thanks Jirka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review