Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=744339 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069@xxxxxxxxx --- Comment #9 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-11-13 12:28:08 EST --- I never thought I would say this, but I think you have too many comments in your spec file. It's actually hurting legibility. You don't have to comment every line... Comments are for unusual situations that require explanation. Some tips: 1. The release tag should start with 1, not 0. 2. If you're not going to build for EL 5 you can remove the following from your spec file: - Buildroot: - %clean entirely - rm -rf %{buildroot} from %install - %defattr from %files 3. The devel subpackage should be arch specific. Change: Requires: %{name} = %{version}-%{release} to Requires: %{name}%{?_isa} = %{version}-%{release} 4. Leave the "*" off of: %{_includedir}/%{name}/* If you don't then the "dieharder" directory will not be owned by the package as it should be. You can leave the trailing "/". That's all I can think of right now. Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review