Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728088 --- Comment #11 from Mo Morsi <mmorsi@xxxxxxxxxx> 2011-11-10 11:48:41 EST --- OK thanks for the update - looks like you addressed all my feedback - rpmlint / koji builds are still green - as Vit mentioned the cp command and devel packages can probably be removed unless there is good reason to keep those there. I feel it might be useful to keep the cached gem in place though as it's good for reference and in order to keep the files provided by rpm and gem installs fairly consistent. None of this is a big deal either way though - Vit's other feedback is also good but not blockers as the package is now in compliance w/ Fedora guidelines. Feel free to implement his suggestions pre/post push. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review