Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728088 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|shawn.starr@xxxxxxxxxx |mmorsi@xxxxxxxxxx --- Comment #10 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-11-07 11:55:06 EST --- This gem doesn't use RSpec, so this issue is irrelevant in this case. Please don't worry too much about Ruby 1.9 compatibility. If there will be necessary some changes, it will be just one of 300 gems, so no big deal. However, you are currently executing the test suite using Rake. I would suggest to replace the "rake test -v --trac" with something like "testrb -Ilib test/tc_*.rb". That allows you to remove the dependency on RDoc and Rake and the patch, which simplifies the maintenance of the library IMO. Moreover: * I would suggest to use %exclude macro instead of deleting files in install section, i.e: %files %exclude %{geminstdir}/ext %exclude %{geminstdir}/.yardoc %exclude %{gemname}-%{version}.gem * I suggest to use: %exclude %{gemdir}/cache/%{gemname}-%{version}.gem since the gem cache has no meaning with RPM. * I suggest to remove the -devel package, because I doubt that it has some meaning in this case. Will somebody except Ruby users base their work on the gem? * I am not exactly sure about the meaning of the "cp %{SOURCE0} %{gemname}-%{version}.gem" command when you can simple call the gem install command with the %{SOURCE0} macro. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review