Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749299 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@xxxxxxx Flag| |fedora-review? --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2011-11-02 17:28:41 EDT --- For the purposes of process bug #749132 details the sponsorship of you. Quick parse: 1) Please include details of how the tar ball is created. 2) BuildRequires: autoconf%{?_isa} BuildRequires: automake%{?_isa} makes no sense since they noarch, all the isa tags are probably over kill but certainly these two are wrong. 3) There is no such package on curl-devel on newer than RHEL5, even if it is satisfied by obsoleted provides possible. Use a dist tag to be more exact. Eventually libcurl-devel should drop the curl-devel %if %{?fedora}%{!?fedora:0} >= 10 || %{?rhel}%{!?rhel:0} >= 6 BuildRequires: libcurl-devel %else BuildRequires: curl-devel %endif is what I use. 4) You have excessive BuildRequires, e.g (lib)curl-devel requires pkgconfig so there is no need to specify it. Similarly gridsite-devel requires openssl-devel, there are probably others. This probably goes for some of your other packages, if you can trim them down preferably to the minimum the better. 5) BuildRequires: libtool%{?_isa} you have twice. 6) On the libs package you almost certainly don't need Requires: curl%{?_isa} Requires: gridsite-libs%{?_isa} >= 1.7 Requires: gsoap%{?_isa} Requires: openssl%{?_isa} since they will auto generated as .so requirements. Check other sub package as well. 7) Pointless comment: #cd build %post devel -p /sbin/ldconfig %postun devel -p /sbin/ldconfig almost certainly not needed, should show up in a rpmlint. 8) Duplication of %doc README LICENSE in at least devel and libs package. 9) %{_sysconfdir}/init.d/lcgdm-dav is presumably an init.d script so should be in /etc/rc.d/init.d http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_on_the_filesystem 10) rpmlint items: rpmlint seems to fail on For the purposes of process bug #749132 details the sponsorship of you. Quick parse: 1) Please include details of how the tar ball is created. 2) BuildRequires: autoconf%{?_isa} BuildRequires: automake%{?_isa} makes no sense since they noarch, these are probably all over kill but certainly these two are wrong. 3) There is no such package on curl-devel on newer than RHEL5, even if it is satisfied by obsoleted provides possible. Use a dist tag to be more exact. Eventually libcurl-devel should drop the curl-devel %if %{?fedora}%{!?fedora:0} >= 10 || %{?rhel}%{!?rhel:0} >= 6 BuildRequires: libcurl-devel %else BuildRequires: curl-devel %endif is what I use. 4) You have excessive BuildRequires, e.g (lib)curl-devel requires pkgconfig so there is no need to specify it. Similarly gridsite-devel requires openssl-devel, there are probably others. This probably goes for some of your other packages, if you can trim them down preferably to the minimum the better. 5) BuildRequires: libtool%{?_isa} you have twice. 6) On the libs package you almost certainly don't need Requires: curl%{?_isa} Requires: gridsite-libs%{?_isa} >= 1.7 Requires: gsoap%{?_isa} Requires: openssl%{?_isa} since they will auto generated as .so requirements. Check other sub package as well. 7) Pointless comment: #cd build %post devel -p /sbin/ldconfig %postun devel -p /sbin/ldconfig almost certainly not needed, should show up in a rpmlint. 8) Duplication of %doc README LICENSE in at least devel and libs package. 9) %{_sysconfdir}/init.d/lcgdm-dav is presumably an init.d script so should be in /etc/rc.d/init.d http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_on_the_filesystem # rpmlint items: 10) Fails on http://svnweb.cern.ch/trac/lcgdm, switch to https since its a permanent 301 relocation. Am surprised that rpmlint does not complain about $ rpm -qp --scripts lcgdm-dav-devel-0.5.0-1.fc15.x86_64.rpm postinstall program: /sbin/ldconfig postuninstall program: /sbin/ldconfig http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries 11) lcgdm-dav-debuginfo.x86_64: E: debuginfo-without-sources Hmm indeed they are not there, see: rpmlint -I debuginfo-without-sources for info and indeed despite %{cmake} being used it's seems something inside mangled your cflags and you built with /usr/bin/gcc -Dlcgdmhtext_EXPORTS -D_LARGEFILE64_SOURCE -D_REENTRANT -DNSTYPE_DPNS -Wall -fPIC -I/usr/include/httpd -I/usr/include/apr-1 -I/usr/include/lcgdm -I/usr/include/dpm -I/home/steve/rpmbuild/BUILD/lcgdm-dav-0.5.0/client -o CMakeFiles/lcgdmhtext.dir/htext_common.c.o -c /home/steve/rpmbuild/BUILD/lcgdm-dav-0.5.0/client/htext_common.c which is not http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review