Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746836 Paul Wouters <paul@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Paul Wouters <paul@xxxxxxxxxxxxx> 2011-11-01 16:39:46 EDT --- WARNING: /vol/home/paul/BUILD/dnssec-system-tray-1.11.p2/dnssec-system-tray.pro:11: Unable to find file for inclusion deployment.pri /vol/home/paul/BUILD/dnssec-system-tray-1.11.p2/dnssec-system-tray.pro:12: Unknown test function: qtcAddDeployment probably due to older F-14 I'm testing on? [paul@bofh paul]$ rpmlint /home/paul/SRPMS/dnssec-system-tray-1.11.p2-1.fc14.src.rpm /home/paul/RPMS/x86_64/dnssec-system-tray-1.11.p2-1.fc14.x86_64.rpm /home/paul/RPMS/x86_64/dnssec-system-tray-debuginfo-1.11.p2-1.fc14.x86_64.rpm dnssec-system-tray.src: W: spelling-error %description -l en_US eg -> Eg, eh, e dnssec-system-tray.src: W: spelling-error %description -l en_US libval -> lib val, lib-val, Libava dnssec-system-tray.src: W: spelling-error %description -l en_US logfiles -> log files, log-files, loginess dnssec-system-tray.x86_64: W: spelling-error %description -l en_US eg -> Eg, eh, e dnssec-system-tray.x86_64: W: spelling-error %description -l en_US libval -> lib val, lib-val, Libava dnssec-system-tray.x86_64: W: spelling-error %description -l en_US logfiles -> log files, log-files, loginess 3 packages and 0 specfiles checked; 0 errors, 6 warnings. MUST items: * OK: Complies to package nameing guidlines * OK: matches base package * OK: Meets package guidelines * OK: Valid license BSD matches source code * OK: Written in Americanized engish as required * OK: COPYING packaged in %doc * OK: spec file legible * OK: source matches upstream source * OK: package compiles and builds on main architecture * OK: buildrequires good, rebuilds in mock * OK: no bad locale handling * OK: no libraries, no ldconfig calls in post/postun * OK: not relocatable * OK: does not create or need to own directories * OK: no duplicate files listed * OK: Does not bundle other libraries * OK: macro use consistent * OK: package contains code or permissable content * OK: no large document files * OK: no header files in base package * OK: no static libraries * OK: no .so files in base package * OK: no devel package dependancy issues * OK: package does not contain .la/.a files * OK: gui dnssec-system-tray.desktop properly installed with desktop-file-install * OK: Packages must not own files or directories already owned by other packages. * OK: filenames are valid UTF-8 SHOULD items: * No translation of description/summary in other languages available * Reviewer tested build in mock and found no missing BuildRequires * no scriplets present * no subpackages present * no pkgconfig present * no outside file dependancies * WARN: missing man page for dnssec-system-tray. Encourage upstream to write one :) Note I was told that you should not use macros for mkdir/cp/install. Consider not using %{__mkdir_p} and %{__install} PASS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review