Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=746824 Paul Wouters <paul@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Paul Wouters <paul@xxxxxxxxxxxxx> 2011-11-01 16:30:39 EDT --- for upstream: mainwindow.cpp: In member function 'void MainWindow::getAnswers()': mainwindow.cpp:247:57: warning: deprecated conversion from string constant to 'char*' rpmlint: [paul@bofh paul]$ rpmlint /home/paul/SRPMS/dnssec-check-1.11.p2-1.fc14.src.rpm /home/paul/RPMS/x86_64/dnssec-check-1.11.p2-1.fc14.x86_64.rpm/home/paul/RPMS/x86_64/dnssec-check-1.11.p2-1.fc14.x86_64.rpm /home/paul/RPMS/x86_64/dnssec-check-debuginfo-1.11.p2-1.fc14.x86_64.rpm dnssec-check.src: W: spelling-error %description -l en_US mechansim -> mechanism (none): E: no installed packages by name /home/paul/RPMS/x86_64/dnssec-check-1.11.p2-1.fc14.x86_64.rpm/home/paul/RPMS/x86_64/dnssec-check-1.11.p2-1.fc14.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 1 warnings. MUST items: * OK: Complies to package nameing guidlines * OK: matches base package * OK: Meets package guidelines * OK: Valid license BSD matches source code * OK: Written in Americanized engish as required * OK: COPYING packaged in %doc * OK: spec file legible * OK: source matches upstream source * OK: package compiles and builds on main architecture * OK: buildrequires good, rebuilds in mock * OK: no bad locale handling * OK: no libraries, no ldconfig calls in post/postun * OK: not relocatable * OK: does not create or need to own directories * OK: no duplicate files listed * OK: Does not bundle other libraries * OK: macro use consistent * OK: package contains code or permissable content * OK: no large document files * OK: no header files in base package * OK: no static libraries * OK: no .so files in base package * OK: no devel package dependancy issues * OK: package does not contain .la/.a files * OK: gui dnssec-check.desktop properly installed with desktop-file-install * OK: Packages must not own files or directories already owned by other packages. * OK: filenames are valid UTF-8 SHOULD items: * No translation of description/summary in other languages available * Reviewer tested build in mock and found no missing BuildRequires * no scriplets present * no subpackages present * no pkgconfig present * no outside file dependancies * WARN: missing man page for dnssec-nodes Encourage upstream to write one :) PASS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review