Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=747031 --- Comment #1 from Jens Petersen <petersen@xxxxxxxxxx> 2011-10-19 03:01:16 EDT --- Thanks Teemu, generally your package looks ok. I have a few smaller comments/suggestions: > %global common_summary Haskell bindings to bibutils, the bibliography conversion utilities I think "Haskell bindings to bibutils" is sufficient and succinct enough for the summary. > %global common_description Haskell bindings to Chris Putnam's bibutils, a\ (I would break the line before "a".:) > For more details about bibutils, please check:\ > <http://www.scripps.edu/~cdputnam/software/bibutils/>.\ > The original API documentation is available here:\ > <http://www.scripps.edu/~cdputnam/software/bibutils/library_specs.html>.\ Not sure both the urls are really necessary (people can get to them from the hackage page anyway: personally I would remove the second sentence anyway. > The package release number refers to the release number of \ > the included bibutils library. I think better to remove this. Anyway you are pretty free to edit the description to your liking. > Release: 0%{?dist} You need to bump this. > License: GPLv2 I see a potential problem here: Bibutils.hsc proclaims itself to be BSD license. Is it because bibutils is GPL that hs-bibutils is saying it is GPL too, or something else? If you are not sure I suggest contacting the maintainer to clarify the license. > # BEGIN cabal2spec : > BuildRequires: ghc-Cabal-devel > BuildRequires: ghc-rpm-macros > BuildRequires: ghc-syb-devel > BuildRequires: ghc-base-prof Actually @DEPENDENCIES@ below is a placeholder for these. So better to place them outside the "cabal2spec" commented block. : > # END cabal2spec : > #BuildRequires: @DEPENDENCIES@ Here! ^ :) > #%define cabal_configure_options -f "opt1 -opt2 ..." You can remove this to get rid of the warning you mentioned: >> ghc-hs-bibutils.src:74: W: macro-in-comment %define > %changelog > * Thu Oct 13 2011 Fedora Haskell SIG <haskell-devel@xxxxxxxxxxxxxxxxxxxxxxx> - 4.12-0 > - initial packaging for Fedora automatically generated by cabal2spec-0.24.1 You need to add a comment to document the changes you make each time you update the spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review