[Bug 746848] Review Request: dbus-sharp - C# bindings for D-Bus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=746848

Peter Gordon <peter@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Peter Gordon <peter@xxxxxxxxxxxxxxxx> 2011-10-19 02:00:36 EDT ---
(In reply to comment #4)
> Although the current packaging guidelines already refer to the new directory
> scheme, it is not yet implemented. Even the mono core packages still expect the
> old-style arch-independent paths. We are currently in the process of updating
> rawhide, but until this has finished, we still have to use the old paths.
> 
> For reference:
> https://fedoraproject.org/wiki/User:Chkr/MonoMultiarchChanges
> https://fedorahosted.org/fpc/ticket/91

Ah, I learned something new today. Excellent, and thank you for the pointers.
;)


> These two warnings are "normal" for mono packages (even if we would solely use
> /usr/lib), they are false positives caused by the fact that mono assemblies are
> not treated as binaries.

That's right - these are both false positives, now that you've explained the
the multi-arch transition. So these can be safely ignored.


> That's only necessary if it is not done automatically via make. In this case it
> happens in the "make install" step.
> 
> [...]
> 
> The assembly is already correctly installed/registered in the GAC.
> 

Aha - I had not noticed that at first. Thank you for the clarification.

In that case, everything looks good to me with the updated spec/SRPM. 


dbus-sharp-0.7.0-2 is APPROVED. Thanks for packaging this! :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]