Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720356 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-10-17 08:45:41 EDT --- (In reply to comment #2) > - License should be MIT, I don't see any references to GPLv2+ or Ruby in any of > the included files. Good spot! Thank you. > - Maybe you could alter the way you run tests by moving the > -I%{buildroot}%{geminstdir}/lib parameter to RUBYOPT. I think that once you use > RUBYOPT, you should place everything in it not to make mess of things. It does make sense. I'll think about it :) > So after you correct the License tag, this package is APPROVED. Thank you for your review. New Package SCM Request ======================= Package Name: rubygem-rack-ssl Short Description: Force SSL/TLS in your app Owners: vondruch Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review