[Bug 720356] Review Request: rubygem-rack-ssl - Force SSL/TLS in your app

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720356

Bohuslav Kabrda <bkabrda@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Bohuslav Kabrda <bkabrda@xxxxxxxxxx> 2011-10-14 04:35:18 EDT ---
- License should be MIT, I don't see any references to GPLv2+ or Ruby in any of
the included files.
- Maybe you could alter the way you run tests by moving the
-I%{buildroot}%{geminstdir}/lib parameter to RUBYOPT. I think that once you use
RUBYOPT, you should place everything in it not to make mess of things.

So after you correct the License tag, this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]