Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731050 --- Comment #5 from Jessica Jones <fedora@xxxxxxxxxxx> 2011-10-11 08:39:28 EDT --- (In reply to comment #4) > $ rpmlint /home/msuchy/rpmbuild/RPMS/noarch/mrepo-0.8.7-4.fc15.noarch.rpm > /home/msuchy/rpmbuild/SRPMS/mrepo-0.8.7-4.fc15.src.rpm ... (omitted for readability) ... > 2 packages and 0 specfiles checked; 11 errors, 18 warnings. > > You should contact upstream to correct FSF address in GPL license text > > There is no need to set execute bit for python scripts in /usr/share. > > I encouradge you to write missing pages and send them to upstream. If you never > write man page then asciidoc is good start. > http://www.methods.co.nz/asciidoc/ > > > mrepo.noarch: E: non-readable /etc/mrepo.conf 0600L > This can be waived as this configuration file can contain login and password. > > Spelling is OK, but rhn, which should be RHN. Okay, will fix that. > > mrepo.src:20: W: mixed-use-of-spaces-and-tabs (spaces: line 20, tab: line 1) > This is self-explanatory. > > > mrepo.src: W: invalid-url Source0: mrepo-0.8.7.tar.bz2 > Tar is now available at > http://dag.wieers.com/home-made/mrepo/mrepo-0.8.7.tar.bz2 > Please fix Source0. > > > Additionally: > Most libraries in: > /usr/share/mrepo/up2date_client/ > are copied from package rhn-client-tools > and libraries in: > /usr/share/mrepo/rhn > are copied from package rhnlib > Both are for some time in Fedora. > I encouradge you talk to upstream to not bundle this libraries to mrepo, but > use those libraries directly from rhnlib and rhn-client-tools. Okay I will liaise with upstream on this and the other issues. > Buildroots and fedattr are obsoleted and there is no need to specify them. Well > at least on Fedora (still needed on RHEL). I assume there is a way around this so that it can be in EPEL too? (This is surely on a wiki page somewhere?) > Instead of > %{_sysconfdir}/rc.d/init.d > you can use macrot: > %{_initddir} Thanks. This last is recommended, or just for info? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review