Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731050 --- Comment #4 from Miroslav Suchý <msuchy@xxxxxxxxxx> 2011-10-10 06:20:01 EDT --- $ rpmlint /home/msuchy/rpmbuild/RPMS/noarch/mrepo-0.8.7-4.fc15.noarch.rpm /home/msuchy/rpmbuild/SRPMS/mrepo-0.8.7-4.fc15.src.rpm mrepo.noarch: W: spelling-error %description -l en_US http -> HTTP mrepo.noarch: W: spelling-error %description -l en_US sftp -> ftp, ftps, s ftp mrepo.noarch: W: spelling-error %description -l en_US rsync -> sync, r sync mrepo.noarch: E: incorrect-fsf-address /usr/bin/rhnget mrepo.noarch: E: zero-length /usr/share/mrepo/up2date_client/distrotype.py mrepo.noarch: E: script-without-shebang /usr/share/mrepo/up2date_client/distrotype.py mrepo.noarch: E: script-without-shebang /usr/share/mrepo/up2date_client/repoBackends/__init__.py mrepo.noarch: E: incorrect-fsf-address /usr/bin/youget mrepo.noarch: E: incorrect-fsf-address /usr/share/doc/mrepo-0.8.7/COPYING mrepo.noarch: E: non-executable-script /usr/share/mrepo/rhn/SSL.py 0644L /usr/bin/python mrepo.noarch: E: non-readable /etc/mrepo.conf 0600L mrepo.noarch: E: incorrect-fsf-address /usr/bin/mrepo mrepo.noarch: E: script-without-shebang /usr/share/mrepo/up2date_client/__init__.py mrepo.noarch: E: script-without-shebang /usr/share/mrepo/up2date_client/up2dateUtils.py mrepo.noarch: W: no-manual-page-for-binary mrepo mrepo.noarch: W: no-manual-page-for-binary youget mrepo.noarch: W: no-manual-page-for-binary rhnget mrepo.noarch: W: no-manual-page-for-binary gensystemid mrepo.noarch: W: non-standard-dir-in-var mrepo mrepo.noarch: W: incoherent-subsys /etc/rc.d/init.d/mrepo $prog mrepo.src: W: spelling-error %description -l en_US http -> HTTP mrepo.src: W: spelling-error %description -l en_US sftp -> ftp, ftps, s ftp mrepo.src: W: spelling-error %description -l en_US rsync -> sync, r sync mrepo.src: W: spelling-error %description -l en_US rhn -> ran, rho, run mrepo.src:101: W: macro-in-comment %{_docdir} mrepo.src:101: W: macro-in-comment %{name} mrepo.src:101: W: macro-in-comment %{version} mrepo.src:20: W: mixed-use-of-spaces-and-tabs (spaces: line 20, tab: line 1) mrepo.src: W: invalid-url Source0: mrepo-0.8.7.tar.bz2 2 packages and 0 specfiles checked; 11 errors, 18 warnings. You should contact upstream to correct FSF address in GPL license text There is no need to set execute bit for python scripts in /usr/share. I encouradge you to write missing pages and send them to upstream. If you never write man page then asciidoc is good start. http://www.methods.co.nz/asciidoc/ > mrepo.noarch: E: non-readable /etc/mrepo.conf 0600L This can be waived as this configuration file can contain login and password. Spelling is OK, but rhn, which should be RHN. > mrepo.src:20: W: mixed-use-of-spaces-and-tabs (spaces: line 20, tab: line 1) This is self-explanatory. > mrepo.src: W: invalid-url Source0: mrepo-0.8.7.tar.bz2 Tar is now available at http://dag.wieers.com/home-made/mrepo/mrepo-0.8.7.tar.bz2 Please fix Source0. Additionally: Most libraries in: /usr/share/mrepo/up2date_client/ are copied from package rhn-client-tools and libraries in: /usr/share/mrepo/rhn are copied from package rhnlib Both are for some time in Fedora. I encouradge you talk to upstream to not bundle this libraries to mrepo, but use those libraries directly from rhnlib and rhn-client-tools. Buildroots and fedattr are obsoleted and there is no need to specify them. Well at least on Fedora (still needed on RHEL). Instead of %{_sysconfdir}/rc.d/init.d you can use macrot: %{_initddir} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review