Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=744339 --- Comment #3 from Jiri Hladky <hladky.jiri@xxxxxxxxx> 2011-10-09 17:54:31 EDT --- Hi Thomas, please see my comments bellow: (In reply to comment #1) > Just a few comments for now: > - Why is the prober source0 commented out? > Did you change the source somehow, so it's not this anymore?: > http://www.phy.duke.edu/~rgb/General/dieharder/dieharder-%{version}.tgz No, I have used the local copy of the source code when I was doing trials to speed up the turned around time. I have switched it back to the http://www.phy.duke.edu/~rgb/General/dieharder/dieharder-%{version}.tgz > > - Why do you: > autoreconf > ./autogen.sh > ? > > ./configure works directly without that and you apply no patches. Good hint. Thanks, I have fixed it now. > - The description looks odd, could you delete the passages with "I have" and > such thinks? I have just copy and paste the original description. I have now changed it so that it's neutral and objective. > - Did you notify upstream of "incorrect-fsf-address" in some files? I cannot find such warning in build.log. My latest trials are at: http://koji.fedoraproject.org/koji/getfile?taskID=3418216&name=build.log http://koji.fedoraproject.org/koji/getfile?taskID=3418217&name=build.log Can you please provide more details what you mean? Thanks! Jirka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review