Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743497 --- Comment #3 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2011-10-06 10:26:25 EDT --- (In reply to comment #1) > Taking this review. From a quick glance (full review forthcoming), everything > looks good, but some items are no longer necessary: > > - BuildRoot declaration (and clean-up in %install) only necessary if you want > to target RHEL 5; you can surround them with %if %{el5} if you do target RHEL 5 > - %clean section only needed in RHEL 5 & 6 (use %if %{rhel} if you want to > target them) My bad; I mean %if 0%{?el5} and %if 0%{?rhel} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review