Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743497 --- Comment #2 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2011-10-06 06:51:04 EDT --- * TODO Review [70%] - [X] Names [2/2] - [X] Package name - [X] Spec name - [X] Package version [2/2] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning - [X] Version number http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag - [X] Release tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] - [ ] Source files match upstream Please provide your own instructions, so the tarball generation is reproducible, rather than using the latest github snapshot. And perhaps use xz rather than gz? e.g. git clone git://github.com/bwalex/tc-play ( cd tc-play && \ git archive --format=tar --prefix=%{name}-%{githash}/ %{githash} \ ) | xz - > %{name}-%{githash}.tar.xz - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]] - [-] License [3/4] - [X] License is Fedora-approved - [X] No licensing conflict - [X] License field accurate - [ ] License included iff packaged by upstream please ask upstream for this - [X] rpmlint [2/2] - [X] on src.rpm tcplay.src: W: invalid-url Source0: bwalex-tc-play-59c6097.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - [X] on x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - [X] Language & locale [2/2] - [X] Spec in US English - [X] Spec legible - [X] Build [3/3] - [X] Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=3405450 - [X] BRs complete - [X] Directory ownership - [-] Spec inspection [5/8] - [X] No duplicate files - [X] File permissions - [X] Filenames must be UTF-8 - [ ] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]]) - [ ] [RHEL] %clean section https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) - [ ] [RHEL 5] %buildroot cleaned on %install as noted in previous message, please indicate if you're targeting el5 and/or el6 - [X] Macro usage consistent - [X] Documentation [1/1] - [X] %doc files are non-essential -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review