[Bug 739331] Rename Review: libreoffice-voikko - Finnish spellchecker and hyphenator extension for LibreOffice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739331

--- Comment #6 from Ville-Pekka Vainio <vpvainio@xxxxxx> 2011-09-25 14:36:28 EDT ---
The extra -O switch comes from the file
/usr/lib64/libreoffice/basis3.4/sdk/settings/settings.mk which is included by
libreoffice-voikko's Makefile. The full options that it passes are:

CC_FLAGS=-c -fpic -fvisibility=hidden
CC_FLAGS+=-O

I think the best way to solve this for now would be to pass "CC_FLAGS=-c -fpic
-fvisibility=hidden" to the build in the spec file and maybe report a
LibreOffice bug.

The rpath comes from the same file:
LIBRARY_LINK_FLAGS=-shared '-Wl,-rpath,$$ORIGIN'
COMP_LINK_FLAGS=$(LIBRARY_LINK_FLAGS)

I found the original review by Caolan and from reading this comment, I think
the $ORIGIN rpath is necessary:
https://bugzilla.redhat.com/show_bug.cgi?id=429550#c4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]