Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739331 --- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-09-25 13:34:47 EDT --- rpmlint output: libreoffice-voikko.src: W: spelling-error Summary(en_US) hyphenator -> hyphenation, hyphenate libreoffice-voikko.src:12: W: macro-in-comment %{name} libreoffice-voikko.src:12: W: macro-in-comment %{version} libreoffice-voikko.x86_64: W: spelling-error Summary(en_US) hyphenator -> hyphenation, hyphenate libreoffice-voikko.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libreoffice/share/extensions/voikko.uno.pkg/voikko.so ['$ORIGIN'] libreoffice-voikko.x86_64: E: zero-length /usr/lib64/libreoffice/share/extensions/voikko.uno.pkg/SettingsDialog_en_US.default 3 packages and 0 specfiles checked; 2 errors, 4 warnings. Please get rid of the rpath in voikko.so. The other are OK. MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK $ md5sum libreoffice-voikko-3.2.tar.gz ../SOURCES/libreoffice-voikko-3.2.tar.gz cd432ee55b424c38d841876db757098f libreoffice-voikko-3.2.tar.gz cd432ee55b424c38d841876db757098f ../SOURCES/libreoffice-voikko-3.2.tar.gz MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. ~OK - I see that an extra "-O" is passed to the compiler before Fedora optflags. Please find out where it comes from and file bugs against libreoffice if necessary. MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned, architecture dependent dependency. N/A MUST: Packages does not contain any .la libtool archives. N/A MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK EPEL: Clean section exists. OK EPEL: Buildroot cleaned before install. OK EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review