Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=738556 --- Comment #5 from Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> 2011-09-21 16:07:23 EDT --- Thanks for your advices, here I am again: (In reply to comment #4) > 1. I don't think you need to pre-gzip man pages. Rpmbuild will take care of > this for you. Additionally, the guidelines are nearly non-existent for man > pages, but I don't think it's necessary to mark them as documentation in > %files. Done. There is a lack of documentation about this. I suppose that any change to the Guidelines in the wiki must be done by the Packaging Committee. There are a lot of unclear topics, I'll try to write them down. > 2. You can drop %deffattr... from %files. Done. > 3. You can drop INSTALL from the documentation as the point of providing a > package is to abstract the end user from having to manually install :) Done. I have dropped other files, like gogoc.conf.sample (redundant) and the GUI-LICENSING because I am not building this, the GUI is only for Windows. I'm talking with upstream about this and they confirmed the whole Linux package is BSD. > 4. gogoc.conf and gogoc.conf.sample are still getting installed with 700 > permissions instead of 644. I would try using "chmod 0644..." instead of using > %attr in %files, i.e.: Done. > 5. The following files were getting added to the RPM twice: > > /var/lib/gogoc/gogockeys.pub > /var/lib/gogoc/tsp-broker-list.txt > /var/lib/gogoc/tsp-last-server.txt > /var/run/gogoc/gogoc-rtadvd.conf Done. I also have doubts about the log files. I have created the directory /var/log/gogoc and included it in the %files section. The only documentation I have found about this is: https://fedoraproject.org/wiki/PackagingDrafts/Logfiles but is very unclear and don't know if it's the "official" recommendation. Should I mark the log files as %config %ghost <filename>? The program does logrotation itself, how do you control a whole dir of log files? > 6. Make sure you run rpmlint on the spec and RPMS. It will catch a lot of > common problems. For example: I have fixed the debuginfo problem adding "-g" in a header file, make wasn't honouring the parameters. Now the results of rpmlint are: $ rpmlint SPECS/gogoc.spec SRPMS/*.rpm RPMS/*/*.rpm gogoc.x86_64: E: non-executable-script /usr/share/gogoc/template/linux.sh 0644L /bin/sh gogoc.x86_64: E: non-executable-script /etc/gogoc/template/linux.sh 0644L /bin/sh gogoc.x86_64: E: non-readable /etc/gogoc/gogoc.conf 0640L gogoc.x86_64: W: log-files-without-logrotate /var/log/gogoc gogoc-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gogoc-1.2/gogoc-1_2-RELEASE/gogoc-tsp/src/net/net_tcp6.c 3 packages and 1 specfiles checked; 4 errors, 1 warnings. The first non-executable-script is the sample script in /usr/share. The second is the script actually used by the program, but it doesn't need execution because is called: "/bin/sh /etc/gogoc/template/linux.sh" The non-readable is because the config file stores password in clear text About log-files-without-logrotate, the program does log rotate itself. I haven't patched the incorrect-fsf-address error because I have read I must not touch the license text. I have submitted the patch upstream for inclusion, actually, I have submitted all the patches to them. They don't have a bug tracker or public repository but told me they'll consider the inclusion in the next release. The updated files: SPEC file: https://github.com/jorti/gogoc-fedora-package/raw/v1.2-8/SPECS/gogoc.spec SRPM file: https://github.com/jorti/gogoc-fedora-package/raw/v1.2-8/SRPMS/gogoc-1.2-8.fc15.src.rpm Thank you. Juan. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review