Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=738556 --- Comment #4 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-09-20 12:19:18 EDT --- Ok, some further suggestions :) 1. I don't think you need to pre-gzip man pages. Rpmbuild will take care of this for you. Additionally, the guidelines are nearly non-existent for man pages, but I don't think it's necessary to mark them as documentation in %files. 2. You can drop %deffattr... from %files. 3. You can drop INSTALL from the documentation as the point of providing a package is to abstract the end user from having to manually install :) 4. gogoc.conf and gogoc.conf.sample are still getting installed with 700 permissions instead of 644. I would try using "chmod 0644..." instead of using %attr in %files, i.e.: chmod 0644 %{buildroot}%{_sysconfdir}/%{name}/%{name}.conf \ %{buildroot}%{_sysconfdir}/%{name}/%{name}.conf.sample 5. The following files were getting added to the RPM twice: /var/lib/gogoc/gogockeys.pub /var/lib/gogoc/tsp-broker-list.txt /var/lib/gogoc/tsp-last-server.txt /var/run/gogoc/gogoc-rtadvd.conf This is due to the fact that you were listing them once on the "%ghost" lines and again with: %{_sharedstatedir}/%{name} %{_localstatedir}/run/%{name} since by default the above will include all files recursively from the named directory. I changed it to: %dir %{_sharedstatedir}/%{name} %dir %{_localstatedir}/run/%{name} and it seems to be fixed. 6. Make sure you run rpmlint on the spec and RPMS. It will catch a lot of common problems. For example: $ rpmlint rpmbuild/gogoc/SPECS/gogoc.spec rpmbuild/gogoc/SPECS/gogoc.spec:56: W: mixed-use-of-spaces-and-tabs (spaces: line 56, tab: line 3) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. You can use "expand" to fix the mixed-use-of-spaces-and-tabs. $ rpmlint rpmbuild/gogoc/RPMS/x86_64/*.rpm gogoc.x86_64: W: conffile-without-noreplace-flag /etc/gogoc/gogoc.conf.sample gogoc.x86_64: E: non-executable-script /usr/share/gogoc/template/linux.sh 0644L /bin/sh gogoc.x86_64: E: non-executable-script /etc/gogoc/template/linux.sh 0644L /bin/sh I assume these are OK/intentional. gogoc-debuginfo.x86_64: E: debuginfo-without-sources 2 packages and 0 specfiles checked; 3 errors, 1 warnings. This needs to be fixed. It looks like the makefile could be stripping the binary. If it doesn't have an option to stop it, you'll need to patch the makefile. Thanks, Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review