Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736015 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #4 from Volker Fröhlich <volker27@xxxxxx> 2011-09-08 16:44:15 EDT --- It's common to group the %files sections at the bottom and %package and %description sections at the top. defattr was found to be not necessary after EPEL 4. Add Changelog, COPYING and README to the base package via %doc. Use the name macro whereever it makes sense to replace the actual name, like in Source0. If you're not aiming for EPEL5 or older, Buildroot, clean section and the rm in the install section are not needed. Replace the .gz in the files sections with .* [makerpm@fedora15 fedfs-utils-0.7.0-1.fc15.src]$ rpmlint ../fedfs-utils-0.7.0-1.fc15.src ~/rpmbuild/RPMS/x86_64/fedfs-utils-* fedfs-utils-admin.x86_64: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace fedfs-utils-admin.x86_64: W: spelling-error %description -l en_US automounted -> auto mounted, auto-mounted, automated fedfs-utils-client.x86_64: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace fedfs-utils-client.x86_64: W: spelling-error %description -l en_US automounted -> auto mounted, auto-mounted, automated fedfs-utils-client.x86_64: W: manual-page-warning /usr/share/man/man8/mount.fedfs.8.gz 141: warning: macro `NF' not defined fedfs-utils-client.x86_64: W: manual-page-warning /usr/share/man/man8/mount.fedfs.8.gz 142: warning: macro `TA' not defined fedfs-utils-client.x86_64: W: manual-page-warning /usr/share/man/man8/mount.fedfs.8.gz 144: warning: macro `FI' not defined fedfs-utils-client.x86_64: W: manual-page-warning /usr/share/man/man8/fedfs-map-nfs4.8.gz 90: warning: macro `NF' not defined fedfs-utils-client.x86_64: W: manual-page-warning /usr/share/man/man8/fedfs-map-nfs4.8.gz 91: warning: macro `TA' not defined fedfs-utils-client.x86_64: W: manual-page-warning /usr/share/man/man8/fedfs-map-nfs4.8.gz 93: warning: macro `FI' not defined fedfs-utils-common.x86_64: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace fedfs-utils-common.x86_64: W: spelling-error %description -l en_US automounted -> auto mounted, auto-mounted, automated fedfs-utils-nsdbparams.x86_64: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace fedfs-utils-nsdbparams.x86_64: W: spelling-error %description -l en_US automounted -> auto mounted, auto-mounted, automated fedfs-utils-server.x86_64: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace fedfs-utils-server.x86_64: W: spelling-error %description -l en_US automounted -> auto mounted, auto-mounted, automated fedfs-utils-server.x86_64: W: non-standard-uid /var/lib/fedfs fedfs fedfs-utils-server.x86_64: W: non-standard-gid /var/lib/fedfs fedfs fedfs-utils-server.x86_64: E: non-standard-dir-perm /var/lib/fedfs 0700L fedfs-utils-server.x86_64: W: no-manual-page-for-binary resolve-junction 6 packages and 1 specfiles checked; 1 errors, 19 warnings. You can try to iron out the glitches in the manpage after it's generated. I don't know, if it is possible to remove the cause. Use the _sharedstatedir macro for /var/lib. The sub-packages should require the common package, see: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package The common package can be labeled noarch. I don't know anything about fedfs-utils, but breaking a quarter of a megabyte into 5 parts is probably not necessary. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review