[Bug 734531] Review Request: unison - File synchronisation tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=734531

--- Comment #2 from yellowcake-@xxxxxxx 2011-08-31 13:06:48 EDT ---
SRPM: http://dl.dropbox.com/u/4023668/unison240-2.40.63-1.fc15.src.rpm

thanks for the quick response. contacted the fedora ocaml guy - rjones. He said
unison is hard to package :-)

(In reply to comment #1)
> Did you try to contact the maintainers? You can find them via the package
> database: https://admin.fedoraproject.org/pkgdb
> 
> Some comments:
> 
> - Use the name macro
> 
I think I'm doing it where it's possible.

> - Run rpmlint on all your packages:
>  unison240-debuginfo.x86_64: E: debuginfo-without-sources
> 
I don't understand this
rpmlint unison240-debuginfo-2.40.63-1.fc15.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

> 
>   Also use the icon in the desktop file.
> 
it is used, isn't it!?

> - Compiler flags are not honored
> 
uhh...how is this with ocmal compiler possible? %{optflags} gives me bad errors

> 
> - Since you require ocaml 3.12 or above, you won't take this package to EPEL5.
> You can therefore drop the clean section, the buildroot rm in the install
> section and the buildroot definition.
> 
Ok, lowered to version 3.11.2 but still not compatible.

> In order to find a sponsor, you should also take part in other reviews.
good idea

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]