Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=734531 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> 2011-08-30 18:48:49 EDT --- Did you try to contact the maintainers? You can find them via the package database: https://admin.fedoraproject.org/pkgdb Some comments: - Use the name macro - License is GPLv3+ (it seems) - Run rpmlint on all your packages: unison240-debuginfo.x86_64: E: debuginfo-without-sources - desktop-file-validate usr/share/applications/fedora-unison-2.40.desktop usr/share/applications/fedora-unison-2.40.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated usr/share/applications/fedora-unison-2.40.desktop: warning: value "Utility;Application;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application" Also use the icon in the desktop file. - Compiler flags are not honored - Try to solve file permissions before the files section - Use -p with install and cp commands; don't use -f with cp though - cat-ing the desktop file can go to the prep section. You could also have a file instead and use sed to place ver_compat. - Since you require ocaml 3.12 or above, you won't take this package to EPEL5. You can therefore drop the clean section, the buildroot rm in the install section and the buildroot definition. In order to find a sponsor, you should also take part in other reviews. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review