[Bug 732205] Review Request: airsched - C++ Simulated Airline Schedule Manager Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732205

--- Comment #8 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-08-25 09:41:21 EDT ---
> - Why are you using a %{mydocs} macro and not just delete the installdox files
> in place and own the %{_docdir}/%{name}-%{version}/ folder in %files?

Hmm, I guess, I never had %doc in a doc package. Then you don't run into that
problem. Seems to be the only way to solve this problem, then.

(In reply to comment #7)
> > - Why the %{?fedora:BuildArch:      noarch}?
> 
> Well, EPEL <= 5 does not support multi-arch sub-packages. Indeed, EPEL 6 now
> supports it. So, I should change that macro into something like:
> %if %{?fedora} || 0%{?rhel} > 5
> BuildArch:      noarch
> %endif

(Your snipped would fail on rhel, because of missing "0" before the fedora
macro.)

I think the cleanest way would be:
%if ! (0%{?rhel} > 5)
BuildArch:     noarch
%endif

This also is quite close to the python default macro for python3 subpackages:
https://fedoraproject.org/wiki/Packaging:Python#Macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]