[Bug 732205] Review Request: airsched - C++ Simulated Airline Schedule Manager Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732205

--- Comment #7 from Denis Arnaud <denis.arnaud_fedora@xxxxxxx> 2011-08-22 16:58:32 EDT ---
(In reply to comment #6)
> - Why are you using a %{mydocs} macro and not just delete the installdox files
> in place and own the %{_docdir}/%{name}-%{version}/ folder in %files?

That is a tricky one :)

Michael Schwendt, my wonderful sponsor, explained, in my first review request,
that issue and the work around I use ever since:
https://bugzilla.redhat.com/show_bug.cgi?id=489233#c9
Indeed, if you have carefully look at the output of rpmbuild, you will see that
the %doc macro first deletes the $RPM_BUILD_ROOT%{_dordir} directory, and
re-creates just aferwards, in order to install into in the base documentation.
----------
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.nJHEil
+ umask 022
+ cd /home/build/dev/packages/BUILD
+ cd airsched-0.1.1
+
DOCDIR=/home/build/dev/packages/BUILDROOT/airsched-0.1.1-1.fc15.x86_64/usr/share/doc/airsched-0.1.1
+ export DOCDIR
+ rm -rf
/home/build/dev/packages/BUILDROOT/airsched-0.1.1-1.fc15.x86_64/usr/share/doc/airsched-0.1.1
+ /bin/mkdir -p
/home/build/dev/packages/BUILDROOT/airsched-0.1.1-1.fc15.x86_64/usr/share/doc/airsched-0.1.1
+ cp -pr AUTHORS ChangeLog COPYING NEWS README
/home/build/dev/packages/BUILDROOT/airsched-0.1.1-1.fc15.x86_64/usr/share/doc/airsched-0.1.1
+ exit 0
--------------


> - Why the %{?fedora:BuildArch:      noarch}?

Well, EPEL <= 5 does not support multi-arch sub-packages. Indeed, EPEL 6 now
supports it. So, I should change that macro into something like:
%if %{?fedora} || 0%{?rhel} > 5
BuildArch:      noarch
%endif

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]