Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226359 --- Comment #2 from Vojtech Vitek <vvitek@xxxxxxxxxx> 2011-08-23 09:45:49 EDT --- (In reply to comment #1) > NO rdist-eu-license.txt - no longer exist, now > http://www.magnicomp.com/rdist/rdist-eu-license.shtml Fixed. > NO specfile is properly named, is cleanly written and uses macros consistently. > -- buildprereq is deprecated s/BuildPreReq/BuildRequires/ (it is tag, not macro, btw) > NO package builds in mock (Rawhide/x86_64). > -- YES after changing BuildPreReq to BuildRequires Ok now. > NO rpmlint is silent. > $ rpmlint rdist.spec > rdist.spec:33: E: buildprereq-use byacc bison > rdist.spec: E: specfile-error warning: line 33: buildprereq is deprecated: > BuildPreReq: byacc bison > 0 packages and 1 specfiles checked; 2 errors, 0 warnings. > rdist.spec: W: invalid-url Source1: > http://www.magnicomp.com/rdist/rdist-eu-license.txt HTTP Error 404: Not Found > 0 packages and 1 specfiles checked; 0 errors, 1 warnings. > > $ rpmlint rdist-6.1.5-51.fc17.src.rpm > rdist.src: W: summary-ended-with-dot C Maintains identical copies of files on > multiple machines. > rdist.src: W: spelling-error %description -l en_US mtime -> mime, time, m time > rdist.src:33: E: buildprereq-use byacc bison > rdist.src: E: specfile-error warning: line 33: buildprereq is deprecated: > BuildPreReq: byacc bison > 1 packages and 0 specfiles checked; 2 errors, 2 warnings. > $ rpmlint rdist-6.1.5-51.fc17.x86_64.rpm > rdist.x86_64: W: summary-ended-with-dot C Maintains identical copies of files > on multiple machines. > rdist.x86_64: W: spelling-error %description -l en_US mtime -> mime, time, m > time > rdist.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/rdist-6.1.5/rdist-licensing-email.txt > rdist.x86_64: W: no-manual-page-for-binary oldrdist > 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Fixed. > Notes: > Maybe put oldrdist in its own package. This would break the backward-compatibility -Server option. See man rdist(1). > Licence change to BSD is based only on copy of email, I am not sure if it is > OK. Re-license granted by the original author, thus OK. Is there anything else, Lukas? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review