Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226359 Lukáš Nykrýn <lnykryn@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #1 from Lukáš Nykrýn <lnykryn@xxxxxxxxxx> 2011-08-15 10:32:39 EDT --- Checked git commit: 2f508312795b1acf021efff24f2376326b60e268 source files match upstream YES rdist-6.1.5.tar.gz NO rdist-eu-license.txt - no longer exist, now http://www.magnicomp.com/rdist/rdist-eu-license.shtml YES rdist-v1.1.tar.bz2 YES package meets naming and versioning guidelines. NO specfile is properly named, is cleanly written and uses macros consistently. -- buildprereq is deprecated YES dist tag is present. YES clean section and buildroot present YES license field matches the actual license YES license is open source-compatible YES license text included in package YES latest version is being packaged YES BuildRequires are proper. N/A compiler flags are appropriate. NO package builds in mock (Rawhide/x86_64). -- YES after changing BuildPreReq to BuildRequires YES debuginfo package looks complete. NO rpmlint is silent. $ rpmlint rdist.spec rdist.spec:33: E: buildprereq-use byacc bison rdist.spec: E: specfile-error warning: line 33: buildprereq is deprecated: BuildPreReq: byacc bison 0 packages and 1 specfiles checked; 2 errors, 0 warnings. rdist.spec: W: invalid-url Source1: http://www.magnicomp.com/rdist/rdist-eu-license.txt HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpmlint rdist-6.1.5-51.fc17.src.rpm rdist.src: W: summary-ended-with-dot C Maintains identical copies of files on multiple machines. rdist.src: W: spelling-error %description -l en_US mtime -> mime, time, m time rdist.src:33: E: buildprereq-use byacc bison rdist.src: E: specfile-error warning: line 33: buildprereq is deprecated: BuildPreReq: byacc bison 1 packages and 0 specfiles checked; 2 errors, 2 warnings. $ rpmlint rdist-6.1.5-51.fc17.x86_64.rpm rdist.x86_64: W: summary-ended-with-dot C Maintains identical copies of files on multiple machines. rdist.x86_64: W: spelling-error %description -l en_US mtime -> mime, time, m time rdist.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/rdist-6.1.5/rdist-licensing-email.txt rdist.x86_64: W: no-manual-page-for-binary oldrdist 1 packages and 0 specfiles checked; 0 errors, 4 warnings. YES final provides and requires look sane. N/A %check is present and all tests pass. YES no shared libraries are added to the regular linker search paths. YES owns the directories it creates. YES doesn't own any directories it shouldn't. YES no duplicates in %files. N/A scriptlets must be sane. YES code, not content. N/A large documentation files must go in a -doc subpackage. YES %docs are not necessary for the proper functioning of the package. YES no headers. YES no pkgconfig files. YES no libtool .la droppings. YES not a GUI app. Notes: Maybe put oldrdist in its own package. Licence change to BSD is based only on copy of email, I am not sure if it is OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review