Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725905 Tomas Mraz <tmraz@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #13 from Tomas Mraz <tmraz@xxxxxxxxxx> 2011-08-17 10:48:56 EDT --- You're right, I somehow overlooked that in the file list. As for the documentation - I don't think splitting it to a separate -doc subpackage is a solution. The configuration file format is really simple and the documentation or example would be pretty minimal and doing a separate subpackage for it would be an overkill. I'd really like to see the global and example module config file directly in the main package. And/or manual page for the p11-kit binary. However I will not block the package on this. rpmlint output: rpmlint -v SRPMS/p11-kit-0.3-1.fc14.src.rpm RPMS/x86_64/p11-kit* p11-kit.src: I: checking p11-kit.src: I: checking-url http://p11-glue.freedesktop.org/p11-kit.html (timeout 10 seconds) p11-kit.src: I: checking-url http://p11-glue.freedesktop.org/releases/p11-kit-0.3.tar.gz (timeout 10 seconds) p11-kit-debuginfo.x86_64: I: checking p11-kit-debuginfo.x86_64: I: checking-url http://p11-glue.freedesktop.org/p11-kit.html (timeout 10 seconds) p11-kit-devel.x86_64: I: checking p11-kit-devel.x86_64: I: checking-url http://p11-glue.freedesktop.org/p11-kit.html (timeout 10 seconds) p11-kit.x86_64: I: checking p11-kit.x86_64: I: checking-url http://p11-glue.freedesktop.org/p11-kit.html (timeout 10 seconds) p11-kit.x86_64: W: no-manual-page-for-binary p11-kit 4 packages and 0 specfiles checked; 0 errors, 1 warnings. A manual page for the p11-kit would be nice however this is not a blocker. The package is named according to the naming guidelines. The package meets licensing and packaging guidelines. The source tarball is the same as the upstream tarball. Note for future - there will have to be probably added gettext if the localization of p11-kit is completed and configure also searches for the gtk-doc binaries. But they are both not needed to build the package now. The requires on the base package should be changed to Requires: %{name}%{?_isa} = %{version}-%{release} But this is again a nitpick, but please change it before the import. The package is ACCEPTed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review