Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722713 --- Comment #4 from Mauricio Cleveland <mauricio.cleveland@xxxxxxxxx> 2011-08-17 01:59:24 EDT --- (In reply to comment #3) > %defattr line is no longer needed unless you are building for the RPEL > > Remove Requires: > http://fedoraproject.org/wiki/Packaging:Guidelines#Requires > Since RPM will find the dependency needed automaticly. > > BuildRoot line is not required unless building for the EPEL > Also each time you update the SPEC file, bump up the release and note the > change in the Changelog OK. > > According to the homepage, the package is GPLv3+ OK. > > Also the %clean section isn't needed except for EPEL > Prefix: tag isn't needed either > OK. > Running rpmlint on the RPM package(not SRPM) gives that you need a man page for > it as well bash-4.2$ rpmlint ace-1.5-4.fc15.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > > Description is too long > http://fedoraproject.org/wiki/Common_Rpmlint_issues#description-line-too-long > OK. > This is how mine would look if I did it, except with my name and email of > course: > http://github.com/ndowens/Fedora-Rpms/raw/master/SPECS/ace.spec > > The only issue that rpmlint gives me is that a man page is needed OK. http://code.google.com/p/curvatura/source/browse/ace.spec http://code.google.com/p/curvatura/source/browse/RPMS/ace-1.5-4.fc15.noarch.rpm http://code.google.com/p/curvatura/source/browse/RPMS/ace-1.5-4.fc15.src.rpm I hope this all right. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review