Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728691 Arun SAG <sagarun@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from Arun SAG <sagarun@xxxxxxxxx> 2011-08-16 23:21:53 EDT --- complete review: + = OK - = NA ? = issue + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: 5c92e93a699905dce2e3f59285013b0a django-registration-0.7.tar.gz 5c92e93a699905dce2e3f59285013b0a django-registration-0.7.tar.gz - Package needs ExcludeArch + BuildRequires correct + Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. http://koji.fedoraproject.org/koji/taskinfo?taskID=3270799 + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. (warning can be ignored) [zer0c00l@gnubox noarch]$ rpmlint django-registration-0.7-2.fc15.noarch.rpm django-registration.noarch: W: spelling-error %description -l en_US signups -> sign ups, sign-ups, signposts 1 packages and 0 specfiles checked; 0 errors, 1 warning - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) SHOULD Items: + Should build in mock. + Should build on all supported archs + Should function as described. Tested the application it works as described + Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag ? Should package latest version https://bitbucket.org/ubernostrum/django-registration/downloads The latest version is 0.8-alpha-1 should we package it? - check for outstanding bugs on package. (For core merge reviews XXXXXXXXXXXX APPROVED XXXXXXXXXXXXXXXXXX We will ship 0.7 version of django-registration -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review