[Bug 596461] Review Request: lzma-sdk - SDK for lzma compression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596461

--- Comment #60 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2011-08-09 16:04:48 EDT ---
So, the reason I ask that question in Comment 59 is because I didn't export "C"
all of the functions in the lzma-sdk library, just the ones that upx needs. If
anything else wants to use other functions in the lzma-sdk from C++ code, those
functions will need the same magic applied. Should be straightforward from the
patch though.

Here's the new SRPM and SPEC I worked up:

New SRPM: http://spot.fedorapeople.org/lzma-sdk-4.6.5-5.fc15.src.rpm
New SPEC: http://spot.fedorapeople.org/lzma-sdk.spec

Here are the bits to fix up upx to use it:

http://spot.fedorapeople.org/upx-3.07-use-lzma-sdk-lib.patch
http://spot.fedorapeople.org/upx.spec

I smoke tested these changes and upx successfully compressed an ELF binary and
it ran afterwards.

As ugly as this might be, I like this package a _LOT_ better. Unfortunately,
given that I basically rewrote this package, I don't think it would be fair for
me to review it. I will, however, offer to comaintain it with you (lzma-sdk,
not upx).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]