[Bug 726080] Review Request: Xnee - X11 environment recorder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=726080

--- Comment #7 from Matthieu Saulnier <casper.le.fantom@xxxxxxxxx> 2011-08-06 10:02:17 EDT ---
Hello,

(In reply to comment #6)
> Some comments:
> 1) xnee doesn't really requires cnee to work. You should remove the Requires on
> cnee for the main package xnee.
Removed

> 2) Without any header, libxnee-devel would be useless.
Added

> 3) Neither cnee nor xnee depend on GTK+ 1. So gtk+-devel as BR is useless.
Removed

> 4) If you don't call the "--enable-static-programs=no" option to ./configure,
> your binaries will still be linked statically to libxnee. Enable this option
> and your Requires on libxnee will be really useful. Notice that you may expect
> some rpath issues. The guidelines may help you in such a case.
Done

Files are updated.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]