Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723703 --- Comment #6 from Jeff Johnston <jjohnstn@xxxxxxxxxx> 2011-08-04 15:43:47 EDT --- (In reply to comment #5) > (In reply to comment #4) > > > > [!] Package does NOT have a %clean section which contains rm -rf %{buildroot} > > > (or $RPM_BUILD_ROOT). (not needed anymore) > > > please remove %{__rm} -rf %{buildroot} > > > > > > > The package no longer has a %clean section. There is an rm -rf buildroot at the > > start of the %install section. Are you claiming this has to be removed as well? > > > > Yes, it is not needed. The buildroot will be cleaned automatically before > %install > > > > [!] Package contains code, or permissable content. > > > See comment above about non-gprof code > > > > > > > The source tarball uses an upstream tarball from git based on a particular > > commit hash. Optionally this could be trimmed via an external script, but there > > is no content that needs to be removed for the build to occur. If it is > > recommended that the tarball be smaller at the cost of having it fetchable > > upstream, I will concur. > > > > It is preferable that the tarball contain no unrelated code. Updated. A warning is now issued on the spec file since the tarball is no longer a URL. Instructions on how to build the tarball are included in the spec file. http://jjohnstn.fedorapeople.org/eclipse-gprof.spec http://jjohnstn.fedorapeople.org/eclipse-gprof-0.7.0-0.1.20110718gitc011a2c7a0.fc17.src.rpm bash $ rpmlint eclipse-gprof-0.7.0-0.1.20110718gitc011a2c7a0.fc17.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. bash $ rpmlint eclipse-gprof-0.7.0-0.1.20110718gitc011a2c7a0.fc17.src.rpm eclipse-gprof.src: W: invalid-url Source0: linuxtools-gprof-SNAPSHOT-c011a2c7a093ad3ba1a04623709f7c9a3650269f-src.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review