Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721069 --- Comment #8 from Mark McLoughlin <markmc@xxxxxxxxxx> 2011-07-21 02:57:39 EDT --- Looks great to me now, still some whining from rpmlint: $ rpmlint rubygem-aeolus-image-0.0.1-3.fc14.noarch.rpm rubygem-aeolus-image.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/aeolus-image-0.0.1/ri/Aeolus/Image/PushCommand/combo_implemented%3f-i.yaml %3f rubygem-aeolus-image.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/aeolus-image-0.0.1/ri/Aeolus/Image/BuildCommand/combo_implemented%3f-i.yaml %3f rubygem-aeolus-image.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/aeolus-image-0.0.1/ri/Aeolus/Image/BaseCommand/is_file%3f-i.yaml %3f 1 packages and 0 specfiles checked; 0 errors, 3 warnings. But that looks like a false positive to me - %3f isn't an RPM macro Also, we need this: - Requires: rubygem(image_factory_console) >= 0.4.0 - Requires: rubygem(imagefactory-console) >= 0.4.0 Finally, there's an upstream 0.0.1 release now. We should use that from an official URL rather than building our own gem -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review