Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: isomaster - an easy to use GUI CD image editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220969 ------- Additional Comments From mszpak@xxxxx 2007-01-08 17:09 EST ------- (In reply to comment #8) > * Package doesn't use our global RPM %optflags for compilation. > It uses a custom -Wall only. Makefile needs a patch to accept > $RPM_OPT_FLAGS or %{optflags} I've never used that flag in my builds. I made a patch (hopefully a good one) and I could also talk with the author about a backport changes to the upstream version, but I don't know if that has sense, because it seems to be used only in RPM builds and there should be something like that in a source Makefile: ifndef OPTFLAGS #common defined by the author GLOBALFLAGS = -O2 -Wall ... else GLOBALFLAGS = ${OPTFLAGS} endif GLOBALFLAGS += flags-speciied-for-program What do you suggest? > * Desktop menu category "Application;System;" is debatable. More > appropriate would be "Application;Utility;" as it is an ordinary > application that works on files, ISO 9660 image files. Ok, but it's in Accessories menu now. Grip is in Sound & Video and xcdroast in System Tools. There are all related with CD (in their own way). > > %clean > > rm -fr %{buildroot} %{_builddir}/%{name} > > Just "rm -fr %{buildroot}" is sufficient. The extracted tarball is > removed automatically after a successful build. Maybe in mock. In my local, custom build directory remains. If it's not a big problem I would prefer this option to stay (for other test builds). > > #BuildRequires: gcc-c++ > > The code is written in C, not C++, anyway. :) I took it from my SPEC file to other project. Btw, project compiled with OPTFLAGS is over 10% larger than the previous one. Is this normal? Thanks for your sugestions. SPEC: http://timeoff.wsisiz.edu.pl/zrzut/isomaster.spec SRPC: http://timeoff.wsisiz.edu.pl/zrzut/isomaster-0.6-6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review