Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: isomaster - an easy to use GUI CD image editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220969 ------- Additional Comments From bugs.michael@xxxxxxx 2007-01-08 09:21 EST ------- * Package doesn't use our global RPM %optflags for compilation. It uses a custom -Wall only. Makefile needs a patch to accept $RPM_OPT_FLAGS or %{optflags} * Desktop menu category "Application;System;" is debatable. More appropriate would be "Application;Utility;" as it is an ordinary application that works on files, ISO 9660 image files. > %clean > rm -fr %{buildroot} %{_builddir}/%{name} Just "rm -fr %{buildroot}" is sufficient. The extracted tarball is removed automatically after a successful build. > #BuildRequires: gcc-c++ The code is written in C, not C++, anyway. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review