Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717019 --- Comment #12 from Jan F. Chadima <jchadima@xxxxxxxxxx> 2011-07-18 06:08:38 EDT --- SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. N/A SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. ? There is no necessity of other languages in this package. SHOULD: The reviewer should test that the package builds in mock. OK: SHOULD: The package should compile and build into binary rpms on all supported architectures. OK: both x86_64 and i386 in rawhide works well. SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. NOT TESTED: SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. OK: SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. OK: %{name}-libs requires %{name} package, %{name}-examples requires %name}-libs and %{name}-devel requires %{name}-examples, %{name}-libs and %{name} SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. N/A: there are no pkgconfig files SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. N/A: No file dependencies here. SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense FAIL: there are no man pages at all, but there is a pdf file with sufficient documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review