Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717019 --- Comment #11 from Jan F. Chadima <jchadima@xxxxxxxxxx> 2011-07-15 05:42:51 EDT --- MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK: directories are: /etc/tnc /etc/tnc/xacml (%name-libs) /usr/include/naaeap/ /usr/include/tncs/ /usr/include/tcg/ /usr/include/imunit/ /usr/include/tncxacml/ (%name-devel) MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) OK: MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. OK: permissions meet the rules. MUST: Each package must consistently use macros. OK: MUST: The package must contain code, or permissable content. OK: MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). N/A: there is lack of documentation MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. OK: MUST: Header files must be in a -devel package. OK: they are MUST: Static libraries must be in a -static package. N/A: There are no static libraries. MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. OK: MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} OK: there is the necessary dependencies. MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. OK: MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. N/A: there is no gui MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. OK: MUST: All filenames in rpm packages must be valid UTF-8. OK: all names are ascii -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review