Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713122 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #7 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-07-17 14:47:30 EDT --- Here are some further comments: - If you use sources from an scm, always checkout a specific revision or changeset, e.g. hg clone -u 80e92ef119a0 https://flyback.googlecode.com/hg/ flyback Otherwise, it's hard to verify the integrity of the sources. It would be even better if upstream released source tarballs and not just deb files. Maybe you can ask him to do this. - As Fabian already wrote, add comments above each PatchX line telling what the patch does. Also, to reduce the number of patches, merge all patch files that have similar goals, e.g. fixing paths. - There's no copyright information in the source files, so the license is GPL+. You should ask upstream to add a copyright header to the source files as mentioned in the GPL license text. The version information in the enclosed GPL.txt does not automatically apply to the sources. - Please use plain shell commands instead of the corresponding macros: http://fedoraproject.org/wiki/PackagingGuidelines#Macros - As there's no BuildRoot field in your spec file, you probably don't plan to support EPEL < 6. Thus, you can also drop the %clean section. - replace %defattr(-,root,root) with %defattr(-,root,root,-) - Please be more specific in %files, i.e. prefer complete or partial filenames over a generic "*" (escpecially, if only a single file is added). - Drop the asterisk from %{_datadir}/%{name}/* for proper directory ownership. - Why do you need the shell script "flyback"? Wouldn't be a symlink sufficient? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review