Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713122 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #6 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2011-06-19 06:41:52 EDT --- Just some quick comments: - You are mixing macro style and variable style (${RPM_BUILD_ROOT} vs. %{buildroot}) - Comment the patches https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review