Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694139 --- Comment #3 from Volker Fröhlich <volker27@xxxxxx> 2011-07-10 16:09:01 EDT --- Quite about every possible build target (besides EPEL4 maybe) ships CMake 2.6 or newer. You don't have an older version anywhere around, so the version restriction is pointless. It is fulfilled whatever may be. You can drop the defattr line, if you don't plan to package to EPEL4. If you don't plan to package for EPEL at all, you can drop Buildroot, the clean section and rm -rf %{buildroot} in the install section. Please see for reference: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines The configuration file points to a log directory, that doesn't exist. Create it or require a package that provides it. Ad translations: Forget the gettext part, but the rest applies. Please use -p when you install the icon to keep the timestamp. Why do you set 755 for an icon? You should probably be more explicit in your files section, given the fact, you only install a few files. For instance: - %{upname}* --> %{upname}.8.* - %{_datadir}/applications/* --> %{_datadir}/applications/%{upname}.desktop While it is not necessary from a technical point of view, it avoids to install things inadvertently. Concerning the CMake flags: It is probably easier to set CMAKE_INSTALL_PREFIX empty, but I haven't tried. I'm pretty certain, "Requires: htmldoc" is not needed to run the program. It also pulls in other packages. I beg your pardon, if I'm wrong. If you BR Doxygen, you should also use it: See INSTALL -- there is a build target for the documentation. I don't know though, whether the output is valuable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review