[Bug 694139] Review Request: openvas-gsd - Greenbone Security Desktop client application for OpenVAS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=694139

--- Comment #2 from Michal Ambroz <rebus@xxxxxxxxx> 2011-07-01 14:07:54 EDT ---
Hello Volker,

(In reply to comment #1)
> Even EPEL 5 ships Cmake 2.6. I think, you don't need the version constraint.
CMakeLists.txt:cmake_minimum_required (VERSION 2.6)
That's the reason I included the version constraint

> Please inform upstream about the incorrect FSF postal address.
I will do. 

> Please see
> http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
I have seen it when packaging the gsd - that guideline is for gettext
localisations. Translations in GSD are not done using gettext, but it uses the
QT functionalities for that. As there are no special guideline for that I have
checked how it is in other projects using the QT (scribus, smplayer, scidavis)
and left it as it is in the translations directory.

> You try to own the directory /etc/openvas, which is already owned by another
> package.
Historical reasons for that - openvas-libraries originally didn't own the
directory so it is owned by each of the openvas packages storing there the
configuration. I will remove it.


> Don't include INSTALL.
OK I will remove it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]