Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717345 --- Comment #7 from Volker Fröhlich <volker27@xxxxxx> 2011-07-10 15:06:02 EDT --- Please leave one blank line between changelog entries. It's better legible. You may need xinetd, but not as a BuildRequires. Putting that as a changelog entry, by the way, doesn't help. Please note all relevant edits to the spec file in the changelog. (The changelog entries also don't require a full stop, when they are not sentences.) The link to the Redhat tutorial in README is dead. As this file heavily suggests to read paper.pdf, I think you should include it. The main configuration file also refers to it. The configuration file example should probably be changed to the reflect the situation in Fedora: /etc/apache doesn't exist and sites are managed differently, apache2ctl doesn't exist. You should probably put disable = yes in the xinetd configuration, for security reasons. Also set "default" to "off". Please use the macro _sharedstatedir instead of %{_var}/lib. Also use the name macro to replace "csync2" in the files section, the source URL and in the install section. You should also try tun run rpmlint after installing the package. This yields: csync2.x86_64: W: incoherent-version-in-changelog 1.35-6 ['1.34-6.fc15', '1.34-6'] csync2.x86_64: E: incorrect-fsf-address /usr/share/doc/csync2-1.34/COPYING csync2.x86_64: W: no-manual-page-for-binary csync2-compare 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Are there any SELinux issues, by the way? Please also respond to the other questions and issues I raised in comment #2! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review